Improved recovery-function of ecdsa.

[orizi]

No description provided.

[reviewable-StarkWare]

This change is 

[orizi]

• Improved recovery-function of ecdsa. #8690 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[TomerStarkware]

@TomerStarkware reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)

[ilyalesokhin-starkware]

corelib/src/ecdsa.cairo line 190 at r1 (raw file):

    state.add_mul(ord - z_div_r, gen_point);
    // Checking if the actual parity of the point's y is different than requested, and if so,
    // flipping the multiplier to match the requested parity.

Suggestion:

    // Checking if the actual parity of the point's y is different than the requested, and if so,
    // flipping the multiplier instead of negating the point to match the requested parity.

[ilyalesokhin-starkware]

@ilyalesokhin-starkware reviewed 1 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)

[orizi]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)

---

corelib/src/ecdsa.cairo line 190 at r1 (raw file):

    state.add_mul(ord - z_div_r, gen_point);
    // Checking if the actual parity of the point's y is different than requested, and if so,
    // flipping the multiplier to match the requested parity.

Done.

[ilyalesokhin-starkware]

@ilyalesokhin-starkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @orizi)

[orizi]

@orizi reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @orizi)