refactor(runner): remove incorrect dead_code suppression from DictTrackerExecScope #8699
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
orizi
requested changes
Nov 18, 2025
Collaborator
orizi
left a comment
orizi
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion
crates/cairo-lang-runner/src/casm_run/dict_manager.rs line 11 at r1 (raw file):
/// The data of the dictionary. data: HashMap<Felt252, MaybeRelocatable>, /// The index of the dictionary in the dict_infos segment.
why?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes an incorrect #[allow(dead_code)] attribute from the idx field in DictTrackerExecScope. This field is actively used and the suppression attribute was misleading.While reviewing code quality attributes, identified that DictTrackerExecScope::idx is incorrectly marked with #[allow(dead_code)]. The field is:Initialized in the constructor (new(), L25)Publicly accessed via get_dict_infos_index() (L72).This false suppression masks legitimate compiler warnings and misleads contributors about the field's usage.