add another UnicodeData.txt location to whitelist #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
No, it's not automatic, you still have to login over SSH and pull down the latest code. (Well, in this case, rebuild the docker image, but that's beside the point). I've done so. |
Collaborator
Author
|
Can we document that somewhere so you're not the only person who can do it? (or better, automate it) |
Owner
Collaborator
Author
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @staticfloat this right? anything needed to deploy this or does it happen automatically on merge? this (currently http://www.unicode.org/Public/9.0.0/ucd/UnicodeData.txt but may change) is downloaded in
doc/Makefileand it's been flaky on travis lately