ensure that submodule bumps are reachable #5070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It occurs sometimes that a submodule is bumped to a PR commit instead of the corresponding canonical branch (as registered in `.gitmodules`). Because we typically use `squash`, that PR commit can subsequently become unreachable, randomly breaking the build of `nimbus-eth2`. Prevent these accidents by only allowing submodule bumps to commits on the branch registered in `.gitmodules`. On private branches, simply update `.gitmodules` to match the personal dev branch.
Contributor
Author
|
Followup from #5068 |
tersec
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It occurs sometimes that a submodule is bumped to a PR commit instead of the corresponding canonical branch (as registered in
.gitmodules). Because we typically usesquash, that PR commit can subsequently become unreachable, randomly breaking the build ofnimbus-eth2. Prevent these accidents by only allowing submodule bumps to commits on the branch registered in.gitmodules. On private branches, simply update.gitmodulesto match the personal dev branch.