Skip to content

Conversation

@alexjba
Copy link
Contributor

@alexjba alexjba commented Aug 21, 2024

Cherry-picking ethereum/go-ethereum#26770

Accept all primitive types in Solidity for EIP-712 from intN, uintN, intN[], uintN[] for N as 0 to 256 in multiples of 8


Co-authored-by: Martin Holst Swende [email protected]
(cherry picked from commit 02796f6bee7e014fd16ad39f0bcd3b665b51e0bb)

Important changes:

  • Something worth noting for reviewers.

Fixing status-im/status-desktop#15946

@status-im-auto
Copy link
Member

status-im-auto commented Aug 21, 2024

Jenkins Builds

Click to see older builds (5)
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ de165f4 #1 2024-08-21 05:25:05 ~1 min tests 📄log
✔️ de165f4 #1 2024-08-21 05:26:27 ~2 min tests-rpc 📄log
✔️ de165f4 #1 2024-08-21 05:28:00 ~4 min linux 📦zip
✔️ de165f4 #1 2024-08-21 05:28:19 ~4 min ios 📦zip
✔️ de165f4 #1 2024-08-21 05:29:16 ~5 min android 📦aar
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 04b9329 #2 2024-08-21 05:31:05 ~59 sec tests-rpc 📄log
✖️ 04b9329 #2 2024-08-21 05:31:14 ~1 min tests 📄log
✔️ 04b9329 #2 2024-08-21 05:31:24 ~1 min android 📦aar
✔️ 04b9329 #2 2024-08-21 05:32:01 ~1 min linux 📦zip
✔️ 04b9329 #2 2024-08-21 05:33:01 ~2 min ios 📦zip
✔️ ac3f966 #3 2024-08-21 06:44:28 ~1 min android 📦aar
✔️ ac3f966 #3 2024-08-21 06:44:59 ~2 min linux 📦zip
✔️ ac3f966 #3 2024-08-21 06:45:18 ~2 min tests-rpc 📄log
✔️ ac3f966 #3 2024-08-21 06:45:37 ~2 min ios 📦zip
✔️ ac3f966 #3 2024-08-21 07:27:42 ~44 min tests 📄log

@alexjba alexjba force-pushed the chore/cherry-pick-solidity-primitive-fix branch from de165f4 to 04b9329 Compare August 21, 2024 05:29
alexjba added a commit to status-im/status-desktop that referenced this pull request Aug 21, 2024
There are two fixes needed here.
1. Status-go fix for unknown primitive when signing the message
2. Fix for Paraswap pairing failure due to required namespaces mismatch

Needs: status-im/status-go#5755
alexjba added a commit to status-im/status-desktop that referenced this pull request Aug 21, 2024
There are two fixes needed here.
1. Status-go fix for unknown primitive when signing the message
2. Fix for Paraswap pairing failure due to required namespaces mismatch

Needs: status-im/status-go#5755
Accept all primitive types in Solidity for EIP-712 from intN, uintN, intN[], uintN[] for N as 0 to 256 in multiples of 8

---------

Co-authored-by: Martin Holst Swende <[email protected]>
(cherry picked from commit 02796f6bee7e014fd16ad39f0bcd3b665b51e0bb)
@alexjba alexjba force-pushed the chore/cherry-pick-solidity-primitive-fix branch from 04b9329 to ac3f966 Compare August 21, 2024 06:42
Copy link
Contributor

@clauxx clauxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! Should fix the issues we have with some dapps when signing typed data!

@alexjba alexjba merged commit 2c43056 into develop Aug 22, 2024
@alexjba alexjba deleted the chore/cherry-pick-solidity-primitive-fix branch August 22, 2024 13:32
alexjba added a commit to status-im/status-desktop that referenced this pull request Aug 22, 2024
There are two fixes needed here.
1. Status-go fix for unknown primitive when signing the message
2. Fix for Paraswap pairing failure due to required namespaces mismatch

Needs: status-im/status-go#5755
alexjba added a commit to status-im/status-desktop that referenced this pull request Aug 26, 2024
There are two fixes needed here.
1. Status-go fix for unknown primitive when signing the message
2. Fix for Paraswap pairing failure due to required namespaces mismatch

Needs: status-im/status-go#5755
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants