-
Notifications
You must be signed in to change notification settings - Fork 1k
DO NOT MERGE: synthetic parallel execution test framework #4817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
graydon
wants to merge
17
commits into
stellar:master
Choose a base branch
from
graydon:re-exec
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmkozh
reviewed
Jul 9, 2025
dmkozh
reviewed
Jul 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks sensible overall, I think the main issue is weird/incorrect fee bump handling.
This comment was marked as outdated.
This comment was marked as outdated.
a866e06
to
7b2af24
Compare
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a special mode you can expose to live traffic from mainnet or testnet (online using
run
or, more commonly, offline usingcatchup
) to test out the new p23 parallel-execution code path for soroban phases.The way it works is that just before running a sequential soroban phase, it:
It then proceeds to run the normal sequential phase as usual, and compares the captured parallel results with the sequential results, logging any differences as errors.
Its behaviour is controlled by two environment variables:
STELLAR_TEST_PARALLEL_EXECUTION
must be set to a nonzero number, which will be used as the parallelism factor for the synthesized parallel phase. So settingSTELLAR_TEST_PARALLEL_EXECUTION=4
will make and run a 4-way parallel phase on 4 threads.STELLAR_COMPARISON_TOLERANCE
is an optional but recommended comma-separated list of difference types to tolerate and not report as errors. Currently I recommend running withSTELLAR_COMPARISON_TOLERANCE=event_topics,fees
though other options are possible (browse the code). This is necessary because there are some small observable differences between p22 and p23 executions, both arising from minor protocol changes and also from the very fact of running in parallel (eg. fees go way down).So overall, you probably want to run something like:
To help diagnose differences, it will also write them to some organized files in the filesystem, under the directory
parallel-tx-diffs
. For example my version just wrote these files: