Completed about_dictionaries koan #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glpuga
approved these changes
Dec 10, 2019
| self.assertEqual(__, cards['yellow dwarf']) | ||
| self.assertEqual(5, len(cards)) | ||
| self.assertEqual(42, cards['green elf']) | ||
| self.assertEqual(42, cards['yellow dwarf']) |
There was a problem hiding this comment.
nit: line break before end of file.
| self.assertEqual(2, len(babel_fish.values())) | ||
| self.assertEqual(True, 'one' in babel_fish.keys()) | ||
| self.assertEqual(False, 'two' in babel_fish.values()) | ||
| self.assertEqual(False, 'uno' in babel_fish.keys()) |
There was a problem hiding this comment.
Q: What type are the return values of values() and keys()?
There was a problem hiding this comment.
It returns list for both.
| self.assertEqual(__, babel_fish['one']) | ||
| self.assertEqual(__, babel_fish['two']) | ||
| self.assertEqual('uno', babel_fish['one']) | ||
| self.assertEqual('dos', babel_fish['two']) |
There was a problem hiding this comment.
Q1: Can None be a valid key?
| self.assertEqual(__, babel_fish['one']) | ||
| self.assertEqual(__, babel_fish['two']) | ||
| self.assertEqual('uno', babel_fish['one']) | ||
| self.assertEqual('dos', babel_fish['two']) |
There was a problem hiding this comment.
Q2: Can None be a valid value?
| self.assertEqual(__, babel_fish['one']) | ||
| self.assertEqual(__, babel_fish['two']) | ||
| self.assertEqual('uno', babel_fish['one']) | ||
| self.assertEqual('dos', babel_fish['two']) |
There was a problem hiding this comment.
May sound like an Idle question, but None is precisely the return value of any function if you forget to call return on it...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed and ready for review!