🔧(keycloak) Fix https required issue in dev mode. #1286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joehybird
force-pushed
the
fix/keycloak-dev-https-required
branch
3 times, most recently
from
f1da4c9 to
e2c8aff
Compare
lunika
reviewed
Aug 18, 2025
compose.yml
Outdated
| - --proxy=edge | ||
| - --hostname-url=http://localhost:8083 | ||
| - --hostname-admin-url=http://localhost:8083/ | ||
| # - --proxy=edge |
There was a problem hiding this comment.
Suggested change
| # - --proxy=edge |
If it's not used, can it be removed?
compose.yml
Outdated
| - --metrics-enabled=true | ||
| healthcheck: | ||
| test: ["CMD", "curl", "--head", "-fsS", "http://localhost:8080/health/ready"] | ||
| test: ['CMD-SHELL', '[ -f /tmp/HealthCheck.java ] || echo "public class HealthCheck { public static void main(String[] args) throws java.lang.Throwable { java.net.URI uri = java.net.URI.create(args[0]); System.exit(java.net.HttpURLConnection.HTTP_OK == ((java.net.HttpURLConnection)uri.toURL().openConnection()).getResponseCode() ? 0 : 1); } }" > /tmp/HealthCheck.java && java /tmp/HealthCheck.java http://localhost:9000/health/live'] |
There was a problem hiding this comment.
I wonder if it's not easier to remove the healthcheck instead of having to maintain this?
There was a problem hiding this comment.
does it seems easier to maintain ? can be moved in a script.
['CMD-SHELL', 'exec 3<>/dev/tcp/localhost/9000; echo -e "GET /health/ready/live HTTP/1.1\r\nHost: localhost\r\nConnection: close\r\n\r\n" >&3; grep "HTTP/1.1 200 OK" <&3']
joehybird
force-pushed
the
fix/keycloak-dev-https-required
branch
2 times, most recently
from
d2f9f01 to
c7b2995
Compare
lunika
approved these changes
Sep 3, 2025
joehybird
force-pushed
the
fix/keycloak-dev-https-required
branch
6 times, most recently
from
5868180 to
858b506
Compare
AntoLC
approved these changes
Sep 10, 2025
joehybird
force-pushed
the
fix/keycloak-dev-https-required
branch
3 times, most recently
from
2085625 to
b6f3ba6
Compare
On some environments keycloak returns a 'HTTPS required' message on login. The same issue was fixed in drive by changing the 'sslRequired' value from 'external' to 'none'. Also upgrade keycloak up to 26.3.2 Signed-off-by: Fabre Florian <[email protected]>
Fix the keyCloakSignIn() function for the new login page. Signed-off-by: Fabre Florian <[email protected]>
joehybird
force-pushed
the
fix/keycloak-dev-https-required
branch
from
b6f3ba6 to
0dd6818
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
On some environments keycloak returns a 'HTTPS required' message on login.
The same issue was fixed in drive by changing the 'sslRequired' value from 'external' to 'none' in all realms configuration (see suitenumerique/drive#291).
Also upgrade keycloak up to 26.3.2