-
Notifications
You must be signed in to change notification settings - Fork 416
✨(frontend) add document visible in list and openable via enter key #1365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6a62c88 to
db4fec0
Compare
c2fccae to
a8feb21
Compare
|
Size Change: +8 B (0%) Total Size: 3.66 MB
|
a8feb21 to
5fe360a
Compare
5fe360a to
e0ef20b
Compare
| } | ||
| `} | ||
| className="--docs--doc-grid-item" | ||
| onKeyDown={handleKeyDown} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have already a link available, why not using it ?
docs/src/frontend/apps/impress/src/features/docs/docs-grid/components/DocsGridItem.tsx
Lines 78 to 85 in e0ef20b
| <StyledLink | |
| $css={css` | |
| width: 100%; | |
| align-items: center; | |
| min-width: 0; | |
| `} | |
| href={`/docs/${doc.id}`} | |
| > |
<StyledLink
$css={css`
width: 100%;
align-items: center;
min-width: 0;
`}
href={`/docs/${doc.id}`}
onKeyDown={(e) => {
if (e.key === 'Enter' || e.key === ' ') {
e.preventDefault();
(e.target as HTMLAnchorElement).click();
}
}}
> There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes good catch ! that was a mistake
CHANGELOG.md
Outdated
| - #1349 | ||
| - #1271 | ||
| - #1341 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has been released already.
| - #1349 | |
| - #1271 | |
| - #1341 |
8dd22f0 to
def0aed
Compare
def0aed to
357f543
Compare
357f543 to
f7ca1ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 !
f7ca1ba to
13394d1
Compare
the document now appears in the list and can be opened using the enter key Signed-off-by: Cyril <[email protected]>
13394d1 to
dfd5dc1
Compare
Purpose
Make documents visible in the list and allow users to open them using the Enter key.
Improves accessibility and user interaction with listed documents.
Proposal
Clarify interaction:
enterdoc.mp4