Skip to content

Conversation

@Ovgodd
Copy link
Collaborator

@Ovgodd Ovgodd commented Sep 11, 2025

Purpose

Make documents visible in the list and allow users to open them using the Enter key.
Improves accessibility and user interaction with listed documents.

Proposal

  • Enable opening the document using the Enter key

Clarify interaction:

  • First Tab focuses the drag handle (for reordering)
  • Second Tab focuses the document and allows opening with Enter
enterdoc.mp4

@Ovgodd Ovgodd requested a review from AntoLC September 11, 2025 08:52
@Ovgodd Ovgodd force-pushed the fix/opening-docs-in-all-docs branch from 6a62c88 to db4fec0 Compare September 11, 2025 08:53
@Ovgodd Ovgodd self-assigned this Sep 11, 2025
@Ovgodd Ovgodd force-pushed the fix/opening-docs-in-all-docs branch 3 times, most recently from c2fccae to a8feb21 Compare September 11, 2025 08:58
@github-actions
Copy link

github-actions bot commented Sep 11, 2025

Size Change: +8 B (0%)

Total Size: 3.66 MB

Filename Size Change
apps/impress/out/_next/static/dc69cb10/_buildManifest.js 0 B -889 B (removed) 🏆
apps/impress/out/_next/static/c8659a64/_buildManifest.js 888 B +888 B (new file) 🆕

compressed-size-action

@Ovgodd Ovgodd force-pushed the fix/opening-docs-in-all-docs branch from a8feb21 to 5fe360a Compare September 11, 2025 09:24
@Ovgodd Ovgodd marked this pull request as ready for review September 11, 2025 11:17
@Ovgodd Ovgodd force-pushed the fix/opening-docs-in-all-docs branch from 5fe360a to e0ef20b Compare September 15, 2025 06:23
}
`}
className="--docs--doc-grid-item"
onKeyDown={handleKeyDown}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have already a link available, why not using it ?

<StyledLink
$css={css`
width: 100%;
align-items: center;
min-width: 0;
`}
href={`/docs/${doc.id}`}
>

          <StyledLink 
             $css={css` 
               width: 100%; 
               align-items: center; 
               min-width: 0; 
             `} 
             href={`/docs/${doc.id}`}
             onKeyDown={(e) => {
              if (e.key === 'Enter' || e.key === ' ') {
                e.preventDefault();
                (e.target as HTMLAnchorElement).click();
              }
            }}
           > 

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes good catch ! that was a mistake

CHANGELOG.md Outdated
Comment on lines 27 to 29
- #1349
- #1271
- #1341
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been released already.

Suggested change
- #1349
- #1271
- #1341

@Ovgodd Ovgodd force-pushed the fix/opening-docs-in-all-docs branch from 8dd22f0 to def0aed Compare September 16, 2025 06:57
@Ovgodd Ovgodd requested a review from AntoLC September 16, 2025 06:58
@Ovgodd Ovgodd force-pushed the fix/opening-docs-in-all-docs branch from def0aed to 357f543 Compare September 16, 2025 08:48
@Ovgodd Ovgodd requested a review from AntoLC September 16, 2025 08:49
@Ovgodd Ovgodd force-pushed the fix/opening-docs-in-all-docs branch from 357f543 to f7ca1ba Compare September 16, 2025 09:03
Copy link
Collaborator

@AntoLC AntoLC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 !

@Ovgodd Ovgodd force-pushed the fix/opening-docs-in-all-docs branch from f7ca1ba to 13394d1 Compare September 16, 2025 09:07
the document now appears in the list and can be opened using the enter key

Signed-off-by: Cyril <[email protected]>
@Ovgodd Ovgodd force-pushed the fix/opening-docs-in-all-docs branch from 13394d1 to dfd5dc1 Compare September 16, 2025 10:52
@Ovgodd Ovgodd merged commit dfd5dc1 into main Sep 16, 2025
21 of 22 checks passed
@Ovgodd Ovgodd deleted the fix/opening-docs-in-all-docs branch September 16, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants