🐛(frontend) fix legacy role computation #1376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -26 B (0%) Total Size: 3.66 MB
|
AntoLC
force-pushed
the
fix/doc-header-role
branch
5 times, most recently
from
00af983 to
637583c
Compare
lunika
approved these changes
Sep 15, 2025
We updated the email addresses for the demo users but forgot to change them in the realm.json file. This commit fixes that oversight.
Before the subpages feature, the user_role was computed thanks to the abilities. This is not the correct way to do it anymore, the abilities are now different. We now have "user_role" in the doc response which is the correct way to get the user role for the current document.
AntoLC
force-pushed
the
fix/doc-header-role
branch
from
637583c to
ecd2f97
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When we invited a user, this user on a child doc had his role indicating "owner" even if he was a "administrator".
Before the subpages feature, the user role was computed thanks to the abilities.
This is not the correct way to do it anymore, the abilities are now different.
We now have
user_rolein the doc response which is the correct way to get the user role for the current document.Proposal
Demo