Skip to content

Conversation

rvveber
Copy link
Collaborator

@rvveber rvveber commented Oct 7, 2025

Should fix #1378

@rvveber rvveber requested a review from AntoLC October 7, 2025 18:43
@rvveber rvveber force-pushed the fix-repeated-redirects branch 2 times, most recently from a42a005 to 7e3056c Compare October 8, 2025 14:40
Copy link
Collaborator

@AntoLC AntoLC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you find the proposal on my side is ok, let's merge ✅

@AntoLC AntoLC force-pushed the fix-repeated-redirects branch 2 times, most recently from 4e6d891 to 3278cfb Compare October 9, 2025 13:12
@rvveber
Copy link
Collaborator Author

rvveber commented Oct 9, 2025

Looks OK to me!

Move redirects from render
to a guarded useEffect
to avoid triggering multiple redirects
on every re-render.
@AntoLC AntoLC force-pushed the fix-repeated-redirects branch from 3278cfb to 546f97c Compare October 9, 2025 19:50
@AntoLC AntoLC added bug Something isn't working frontend labels Oct 9, 2025
Copy link

github-actions bot commented Oct 9, 2025

Size Change: +87 B (0%)

Total Size: 3.66 MB

Filename Size Change
apps/impress/out/_next/static/61fdc168/_buildManifest.js 0 B -882 B (removed) 🏆
apps/impress/out/_next/static/25e5d865/_buildManifest.js 881 B +881 B (new file) 🆕

compressed-size-action

@AntoLC AntoLC merged commit 546f97c into main Oct 9, 2025
29 of 31 checks passed
@AntoLC AntoLC deleted the fix-repeated-redirects branch October 9, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Frontend: Auth: Move redirect function out of render cycle to avoid repeated redirects

2 participants