Adding a minimum character threshold #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new `minChars` setting where the filter is only applied to a table when at least `minChars` characters are entered.
|
Also, I'm not sure what tool you're using for minification but I'm happy to go ahead and use that to provide the updated minified code as well. |
|
Actually I went ahead and added a minified lib, will update the source files in PR #25 for the website next... |
|
I've incorporated this into 1.5.5 but did not appropriately credit you. Do you want to submit a new PR and just update the README.md with your info so you get contributor credit/link or shall I just thank you and update myself? I'm sorry about that. |
|
Hi, I just saw this note and I see I'm mentioned in the Readme. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
minCharssetting which sets the minimum number of characters a user needs to enter before the filter is applied to a table. This is a common request from UX designers.I have another PR for the
gh-pagesbranch coming in a minute...