Skip to content

Conversation

@imor
Copy link
Contributor

@imor imor commented Oct 31, 2025

ETL pipelines will also be configured from the analytics buckets page but instead of copying all tables into one destination, pipelines will create one destination schema for each source namespace. This is achieved by making the destination namespace optional in the api. If the namespace is send by the client, old behaviour is maintained. If it is omitted, new behaviour will occur.

Related management api PR: https://github.com/supabase/infrastructure/pull/27112

@coveralls
Copy link

Pull Request Test Coverage Report for Build 18969096029

Details

  • 77 of 86 (89.53%) changed or added relevant lines in 4 files are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.001%) to 82.316%

Changes Missing Coverage Covered Lines Changed/Added Lines %
etl-destinations/src/iceberg/destination.rs 66 67 98.51%
etl-replicator/src/core.rs 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
etl/src/workers/table_sync.rs 1 77.47%
etl/src/replication/table_sync.rs 2 82.27%
etl/src/concurrency/stream.rs 4 82.22%
Totals Coverage Status
Change from base Build 18963584317: 0.001%
Covered Lines: 15678
Relevant Lines: 19046

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 18969096029

Details

  • 77 of 86 (89.53%) changed or added relevant lines in 4 files are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.001%) to 82.316%

Changes Missing Coverage Covered Lines Changed/Added Lines %
etl-destinations/src/iceberg/destination.rs 66 67 98.51%
etl-replicator/src/core.rs 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
etl/src/workers/table_sync.rs 1 77.47%
etl/src/replication/table_sync.rs 2 82.27%
etl/src/concurrency/stream.rs 4 82.22%
Totals Coverage Status
Change from base Build 18963584317: 0.001%
Covered Lines: 15678
Relevant Lines: 19046

💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 31, 2025

Pull Request Test Coverage Report for Build 18974280377

Details

  • 201 of 210 (95.71%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 82.467%

Changes Missing Coverage Covered Lines Changed/Added Lines %
etl-destinations/src/iceberg/destination.rs 190 191 99.48%
etl-replicator/src/core.rs 0 8 0.0%
Totals Coverage Status
Change from base Build 18963584317: 0.2%
Covered Lines: 15809
Relevant Lines: 19170

💛 - Coveralls

@imor imor changed the title feat: one ns for one schema for iceberg destination feat: allow creating one namespace for one schema for iceberg destination Oct 31, 2025
@imor imor marked this pull request as ready for review October 31, 2025 12:43
@imor imor requested a review from a team as a code owner October 31, 2025 12:43
@iambriccardo
Copy link
Contributor

@codex review

Copy link
Contributor

@iambriccardo iambriccardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@imor imor merged commit ac3e76e into main Oct 31, 2025
10 checks passed
@imor imor deleted the rs/one-ns-for-one-schema branch October 31, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants