Skip to content

Conversation

@teemingc
Copy link
Member

@teemingc teemingc commented Dec 9, 2023

The types for the cloudflare workers adapter plugin method requires an object as a parameter. This PR makes that optional so it's in tune with the docs https://kit.svelte.dev/docs/adapter-cloudflare-workers#usage

import adapter from '@sveltejs/adapter-cloudflare-workers';

export default {
	kit: {
-		adapter: adapter({ })
+		adapter: adapter()
	}
};

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2023

🦋 Changeset detected

Latest commit: 071c5fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-cloudflare-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann benmccann changed the base branch from master to version-2 December 9, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants