Skip to content

Conversation

@wackbyte
Copy link
Contributor

@wackbyte wackbyte commented Jun 1, 2024

Replaces the old data-sveltekit-prefetch attribute with data-sveltekit-preload-code in certain tests. This removes all mention of the attribute from the repository. (other than changelogs, of course)


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Jun 1, 2024

⚠️ No Changeset found

Latest commit: 36eebc2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this change happened prior to 1.0, so I don't think we were keeping the old version around to test against it or anything like that. we could probably use any attribute here, but makes sense to update it anyway
https://github.com/sveltejs/kit/blob/main/packages/kit/CHANGELOG.md#100-next565

@benmccann benmccann merged commit da4b0cd into sveltejs:main Jun 5, 2024
@wackbyte wackbyte deleted the prefetch-to-preload-code branch June 6, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants