-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
@sveltejs/package: Assume no svelte 3 if can't read version with semver (pnpm calalog) #13553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Co-authored-by: Ben McCann <[email protected]>
Co-authored-by: Ben McCann <[email protected]>
|
I don't really know if this is safe. What happens if it is a Svelte 3 app with a |
|
You are right, this is not "safe". I'll look at this later :) |
|
Done with #13850 |
|
Oh no, I didn't realize you made a PR many weeks ago for this already - sorry |
I'm using
pnpmand thecatalogfeature.It's nice in monorepos to manage deps & version in one place. (+ you can name & group deps)
In
package.json:{ "peerDependencies": { "svelte": "catalog:svelte-dep" } }An in
pnpm-workspace.yamlBUT, it's not
semverstandard. :( (Maybe one day?)That's why I would suggest this fix ?
Feel free to le me know what do you think
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits