fix: correctly set sequential focus navigation starting point when using the hash router #13860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 71ac4d4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dominikg
reviewed
Jun 6, 2025
| * @returns {string} | ||
| */ | ||
| function get_id(url) { | ||
| return decodeURIComponent(app.hash ? (url.hash.split('#')[2] ?? '') : url.hash.slice(1)); |
There was a problem hiding this comment.
is url hash formatted like https://example.com/#<apphash>#<otherhash> ?
in that case, is it sure that apphash and otherhash both can't contain # char?
otherwise it would be better to take app.hash and remove it from the beginning of url hash if it is there 🤔
There was a problem hiding this comment.
I could've sworn we have a similar function already (I haven't looked closer yet though)
|
Closed in favour of #13884 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression caused by #10856 that didn't take hash routing into account when trying to set the sequential focus navigation starting point. It now correctly determines the hash and uses a cleaner fix than before with
element.focus()instead oflocation.replace(although used in a bit of a hacky way but not anymore hacky than the previous PR).I've tested on Chrome and Firefox on Windows but will need to test this on Safari too. Maybe CI can do that for me..focus()does not work on Safari and Firefox Ubuntu 😄Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits