fix: generate correct SSR code for the case where pending
is an attribute
#16919
+22
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16886
There were two problems here: the first is that when
pending
is an attribute we weren't checking if the fragment contained async...this means if you did use await in a boundary with a pending attribute it was not creating the$$render.async
wrapper.However, that showcased another problem in that generated code:
if
pending
is truthy instead of just invoking it (since it will push it's content to the$$renderer
) we were also pushing to the template the return value (which isundefined
since it's not returning anything.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint