Skip to content

[feat] add Action as a type for use:action #7347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[feat] add Action as a type for use:action #7347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7303f2f
add `Action` type
ivanhofer Mar 7, 2022
4733566
remove `extends any`
ivanhofer Mar 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/runtime/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ export {
hasContext,
tick,
createEventDispatcher,
Action,
SvelteComponentDev as SvelteComponent,
SvelteComponentTyped
} from 'svelte/internal';
17 changes: 17 additions & 0 deletions src/runtime/internal/dom.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,3 +732,20 @@ export function get_custom_elements_slots(element: HTMLElement) {
});
return result;
}


type ActionWithParams<Node extends HTMLElement = HTMLElement, Params = any> = (
node: Node,
options: Params
) => {
update?: (params: Params) => void
destroy?: () => void
}

type ActionWithoutParams<Node extends HTMLElement = HTMLElement> = (node: Node) => {
destroy?: () => void
}

export type Action<Node extends HTMLElement = HTMLElement, Params = void> = void extends Params
? ActionWithoutParams<Node>
: ActionWithParams<Node, Params>