test(ns-asyncapi-3): add tests for AsyncAPI 3 namespace #5039
Conversation
|
|
||
| return FixedFieldsVisitor.prototype.ObjectElement.call(this, objectElement); | ||
| } | ||
| const result = FixedFieldsVisitor.prototype.ObjectElement.call(this, objectElement); |
There was a problem hiding this comment.
Handling of Multi Format Schema based on MessageVisitor from AsyncAPI 2 namespace.
| * @public | ||
| */ | ||
| export interface MultiFormatSchemaLikeElement extends ObjectElement { | ||
| hasKey: (value: 'schemaFormat') => true; |
There was a problem hiding this comment.
Question: should we be checking for both schemaFormat and schema presence or is schemaFormat enough? This is for cases where we can have ReferenceElement, SchemaElement or MultiFormatSchemaElement. Currently recognising each element:
- ReferenceElement - recognised when
$refis present, e.g.:
$ref: <value>
$ref: <value>
prop: <value>
$ref: <value>
schemaFormat: <value>- MultiFormatSchemaElement - recognised when
schemaFormatis present, e.g.:
schemaFormat: <value>
schemaFormat: <value>
schema: <value>
schemaFormat: <value>
prop: <value>- SchemaElement - defaulted to if element was not recognised as
ReferenceElementorMultiFormatSchemaElement, e.g.:
prop: <value>
schema: <value>
| fixedFields: { | ||
| action: { $ref: '#/visitors/value' }, | ||
| channel: { $ref: '#/visitors/value' }, | ||
| channel: OperationChannelVisitor, |
There was a problem hiding this comment.
Operation.channel is a ReferenceElement but I added a separate visitor for it, so that we can decorate it with metadata (referenced-element: channel). Not sure if we can do it in another way, if we want to have separate visitors for Operation.channel and OperationReply.channel, and if we want the metadata for them to be different, as currently they both use this visitor.
Add tests and fixes related to them.
TODO:
MultiFormatSchema) => verified and adjusted based on snapshots