bug(deeplinking): escaping is breaking whitespaces & underscored tags/ids #4953
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves our Deep Linking implementation:
%20instead of__-based escaping are still supported, but deprecated and tagged for removal in v4.0Motivation and Context
Fixes #4895 and may also solve #4929.
How Has This Been Tested?
I added new unit and integration tests, and modified a few existing ones.
There should be no breaking changes to overall functionality, as the new tests cover any gaps left by modifications to the existing tests.
Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests