Skip to content

Conversation

@shockey
Copy link
Contributor

@shockey shockey commented Oct 16, 2018

Description

This PR improves our Deep Linking implementation:

  • Tags and operationIds that contain underscores and whitespace are now tested and working properly
  • Operations lacking operationIds are now tested and working properly
  • Tag and operationId whitespace is now escaped with %20 instead of _
  • Links relying on _-based escaping are still supported, but deprecated and tagged for removal in v4.0

Motivation and Context

Fixes #4895 and may also solve #4929.

How Has This Been Tested?

I added new unit and integration tests, and modified a few existing ones.

There should be no breaking changes to overall functionality, as the new tests cover any gaps left by modifications to the existing tests.

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@shockey shockey changed the title bug(deeplinking): escaping is breaking whitespace & underscored tags/ids bug(deeplinking): escaping is breaking whitespaces & underscored tags/ids Oct 16, 2018
@shockey shockey merged commit 3c3b7e0 into master Oct 16, 2018
@shockey shockey deleted the bug/4895 branch November 26, 2018 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deep linking does not work without operationId

2 participants