Fix span of nodes with decorators, parameter properties, and class members with accessibility #581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dsherret
commented
Jan 11, 2020
dsherret
commented
- Spans of class members and classes should include decorators.
- Fix hi position for class parameter properties.
- Fix span of members with accessibility.
dsherret
changed the title
|
I think the spans of function nodes with decorators might be still incorrect (not going to bother with them for this PR as they're not supported in typescript). |
dsherret
commented
Jan 11, 2020
- Fix hi position for class parameter properties. - Fix span of members with accessibility.
dsherret
force-pushed
the
fixClassAndClassMemberStartsToIncludeDecs
branch
from
9a50575 to
b24421f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.