-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
refactor(es/typescript): Reimplement TypeScript pass #7202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Making a visitor multi-pass may make it significantly slower |
I will run a performance benchmark after I finish this pull request. |
strip into multipass9d72649 to
8c673e3
Compare
b75ecb7 to
26f43bc
Compare
fb2b890 to
a70631c
Compare
branch typescript c4ad213branch main 4623b3e |
47953bc to
078d407
Compare
...ences/ClassAndModuleThatMergeWithStaticFunctionAndExportedFunctionThatShareAName.1.normal.js
Show resolved
Hide resolved
crates/swc/tests/tsc-references/exportAssignmentMergedInterface.1.normal.js
Show resolved
Hide resolved
07d6736 to
a007015
Compare
|
@kdy1 This pull request is ready for review. |
- use `Visitmut` instead `Fold` - support verbatim_module_syntax
753cf62 to
cc6e608
Compare
crates/swc/tests/tsc-references/bitwiseNotOperatorWithStringType.1.normal.js
Outdated
Show resolved
Hide resolved
crates/swc/tests/tsc-references/defaultExportsCannotMerge01.2.minified.js
Show resolved
Hide resolved
crates/swc_ecma_transforms_typescript/tests/fixture/issue-3073/4/output.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!!!
swc-bump:
- swc_ecma_codegen
- swc_ecma_transforms_base
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated review comment generated by auto-rebase script


Description:
Bugfixes
let/vardeclarations in TypeScript namespaces should be mutable.New Features
Deprecated
TsEnumConfigis deprecatedtreat_const_enum_as_enumtransform option is deprecated.ts_enum_is_readonlyassumption option is deprecated.BREAKING CHANGE:
TypeScript Config is changed.
Related issue:
declared members should not be type only #5197declare classincorrectly removed #7676