Many additional Windows fixes #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WSAPollFD `revents` seems to contain POLLRDNORM and not POLLRDBAND (or'd together equals POLLIN). This means we should check for an intersection with POLLIN to claim a "read" event
Windows doesn't like this flag ever for AF_UNIX, so don't add it in that case either
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
=======================================
Coverage 94.58% 94.59%
=======================================
Files 62 62
Lines 4025 4032 +7
=======================================
+ Hits 3807 3814 +7
Misses 218 218 ☔ View full report in Codecov by Sentry. |
we need to send an error through if we're waiting to read and an error happens, but making sure we only error if no actual reading occurred
turns out fixing SocketPool<Poll> fixes mishandling of disconnect errors
This reverts commit 86ed1be.
|
lol, after testing locally back and forth, I think this PR is RTG. Please squash and merge if you can |
|
OK I got bored and added Windows to the test suite... |
|
ah I did not squash — sorry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings greenlights to every test except datagram stuff.
Also fixes an edgecase affecting any user of
SocketPool<Poll>