Skip to content

Conversation

@RReichert
Copy link
Contributor

@RReichert RReichert commented May 7, 2022

Background

This PR is one of two options (see other option #113)

This is a follow on PR after #111 was merged in. In the specified PR I added the following lines to the find_package scripts (this example is for albatross but the same can be said for a number of other orion repositories):

option(albatross_ENABLE_DOCS "" false)
option(albatross_ENABLE_EXAMPLES "" false)
option(albatross_ENABLE_TESTS "" false)
option(albatross_ENABLE_TEST_LIBS "" false)

This caused a lot of warning messages to be triggered (which I've missed my testing). Personally I prefer to have all the features disabled by default when including them as submodules, to avoid having them enabled accidentally when one of them becomes available in a submodule project. Say that a new project gets added with HAS_TESTS as a project feature, that will be by default enabled when the auto submodule updates roll up through the other repositories.

NOTE: if this isn't a good viable solution, the alternative to dealing with these warnings is to properly disable only features that are available in the submodule which I'm happy to do.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@RReichert RReichert changed the title Removed warning messages Removed warning messages (Option #1) May 7, 2022
@RReichert RReichert requested a review from woodfell May 7, 2022 12:34
@RReichert RReichert closed this May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants