Removed warning messages (Option #1) #112
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.








Background
This PR is one of two options (see other option #113)
This is a follow on PR after #111 was merged in. In the specified PR I added the following lines to the
find_packagescripts (this example is for albatross but the same can be said for a number of other orion repositories):This caused a lot of warning messages to be triggered (which I've missed my testing). Personally I prefer to have all the features disabled by default when including them as submodules, to avoid having them enabled accidentally when one of them becomes available in a submodule project. Say that a new project gets added with HAS_TESTS as a project feature, that will be by default enabled when the auto submodule updates roll up through the other repositories.
NOTE: if this isn't a good viable solution, the alternative to dealing with these warnings is to properly disable only features that are available in the submodule which I'm happy to do.