Automatically create alias targets in cmake [ESD-2467] #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… goal is to get aliases of all target
Update variable names
…tomaticallyCreateAliasTargetsInCmake
lucasle-sn
requested review from
RReichert and
woodfell
and removed request for
RReichert
RReichert
reviewed
Aug 9, 2022
SwiftTargets.cmake
Outdated
| BRIEF_DOCS "Target's source directory" | ||
| FULL_DOCS "Identical use as SOURCE_DIR except that this applies to ALL target types, including INTERFACE") | ||
|
|
||
| set(project_alias "swiftnav" CACHE STRING "Alias for project") |
There was a problem hiding this comment.
I don't believe you need to make this a cache variable, the following will suffice:
set(SWIFTNAV_ALIAS swiftnav)
Also global variables are captialized
SwiftTargets.cmake
Outdated
| endif() | ||
|
|
||
| foreach(target_dependency ${target_dependencies}) | ||
| if (TARGET ${target_dependency}) |
There was a problem hiding this comment.
to avoid the nesting you use the following technique:
if (TARGET ${target_dependency})
continue()
endif()
get_target_property(swift_dep_alias ${target_dependency} ALIASED_TARGET)
if (NOT swift_dep_alias)
continue()
endif()
get_target_property(target_dep_type ${target_dependency} TYPE)
...
RReichert
approved these changes
Aug 9, 2022
lucasle-sn
commented
Aug 9, 2022
Comment on lines
+420
to
+431
| if (NOT TARGET ${SWIFTNAV_ALIAS}::${target_dependency}) | ||
| continue() | ||
| endif() | ||
|
|
||
| get_target_property(_swift_dep_alias ${SWIFTNAV_ALIAS}::${target_dependency} ALIASED_TARGET) | ||
| if (NOT _swift_dep_alias) | ||
| continue() | ||
| endif() | ||
|
|
||
| if (${_swift_dep_alias} STREQUAL ${target_dependency}) | ||
| message(WARNING "Linking \"${target_dependency}\" as a dependency of target \"${target}\". Please use alias \"${SWIFTNAV_ALIAS}::${target_dependency}\" instead.") | ||
| endif() |
There was a problem hiding this comment.
Extra check to ensure the recommended alias is the real alias.
antrikshsrivastava
approved these changes
Aug 9, 2022
…tomaticallyCreateAliasTargetsInCmake
|
Kudos, SonarCloud Quality Gate passed!
|
lucasle-sn
deleted the
lucasle/esd-2467/AutomaticallyCreateAliasTargetsInCmake
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket
https://swift-nav.atlassian.net/browse/ESD-2467
Design
swift_add_target()to automatically create alias for all library targets, when callingswift_add_***_library().swift_validate_targets()to return warning if swift target links to "not alias" dependencies.Related PRs