Remove checks introduced between clang tidy 6 and 14 #125
Conversation
krisukox
force-pushed
the
krisukox/clang-tidy-14
branch
from
57366bb to
279d2e6
Compare
krisukox
force-pushed
the
krisukox/clang-tidy-14
branch
from
279d2e6 to
2a73bbb
Compare
Enable clang-tidy for targets created without swift_* functions
| message(WARNING "No sources to lint for clang-tidy-all, that doesn't sound right") | ||
| else() | ||
| list(REMOVE_DUPLICATES all_abs_srcs) | ||
| list(FILTER all_abs_srcs EXCLUDE REGEX "pb.cc") |
There was a problem hiding this comment.
What were these files?
There was a problem hiding this comment.
Generated nanopb files? Used by real-time replay and fast start
FindStarling.cmake
Outdated
| starling-util | ||
| SOURCE_DIR starling | ||
| SYSTEM_HEADER_FILE "pvt_driver/runner/pvt_runner.h" | ||
| SYSTEM_INCLUDES |
There was a problem hiding this comment.
Interesting. Starling is already using these linting settings so I'm surprised its headers are causing linting issues.
There was a problem hiding this comment.
I had a problem with starling-replay headers in the orion-engine PR.
We don't want to update the linter in the orion-engine right now, so I reverted this change.
There was a problem hiding this comment.
find_program(CLANG_TIDY NAMES clang-tidy-6.0 clang-tidy)We're going to want to change this from clang-tidy-6.0 to clang-tidy-14
We should probably do the same thing for ClangFormat.cmake
@woodfell @RReichert will we break anything if we make it:
find_program(CLANG_FORMAT NAMES clang-format-14 clang-format)instead of that long list of names ??
|
Did some light testing on mac and seems to work well. I was also curious if clang-tidy-6.0 would be able to handle the new |
|
@RReichert @woodfell anything you'd like to add before we merge? |
|
Kudos, SonarCloud Quality Gate passed!
|
This PR:
WITHOUT_SWIFT_TYPESoption to theswift_create_clang_tidy_targetsfunctionTested here: