Project project_BUILD_* variables #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodfell
force-pushed
the
woodfell/protect_option_build_variables
branch
from
a31ba49 to
8b9c1da
Compare
|
This only projects against setting these variables in the commandline or parent project right? Are there also cases where these are being set within the project itself after Swift options is called? |
|
They could be overwritten later on, but there is nothing we can really do about that. I keep coming across cases of |
benjaminaltieri
approved these changes
Sep 12, 2019
This was referenced Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some places internal cmake variables are being set manually, either on the command line or from a higher level project. Setting
project_BUILD_${feat}vars breaks the internal feature enable/disable logic and must not be allowed. Projects can TESTproject_BUILD_${feat}to decide whether to build something or not, for example unit tests, but they must never be set manually. The correct way is to setproject_ENABLE_${feat}instead.This does not fix any place which actually does this, just ensure that an error is thrown if someone uses these options erroneously.