[ESD-2242] Fix integer promotion issues in generated macros #1083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodfell
force-pushed
the
woodfell/integer_promotion
branch
from
bffccff to
93af9c4
Compare
woodfell
force-pushed
the
woodfell/integer_promotion
branch
from
93af9c4 to
a17f5c8
Compare
woodfell
changed the title
woodfell
commented
Nov 5, 2021
| (((flags) >> {}_SHIFT) \\ | ||
| & {}_MASK)""".format( | ||
| base_string, base_string, base_string | ||
| (({})(((flags) >> {}_SHIFT) \\ |
Contributor
Author
There was a problem hiding this comment.
This is the only interesting change, everything else is generated
silverjam
approved these changes
Nov 5, 2021
samvrlewis
approved these changes
Nov 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated bitfield macros contains lots of integer promotion when operating on smaller data types. These can cause compiler warnings in consumers of libsbp when compiled with
-Wconversion