Add some helpers for managing context timeouts[CPP-693] #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notoriaga
reviewed
Mar 30, 2022
src/context.rs
Outdated
| } | ||
|
|
||
| pub fn cancel_rx(&self) -> Receiver<()> { | ||
| self.cancel_rx.clone() |
There was a problem hiding this comment.
I think you might need to increment num_chans here. But also not sure how you can decrement it if the channel gets dropped. These channels aren't really intended to be apart if the public api, why do you need them?
There was a problem hiding this comment.
@notoriaga I was trying to use it here:
swift-nav/swift-toolbox#487
There was a problem hiding this comment.
@notoriaga We can get this merged in and then use the new release in swift-toolbox PR.
john-michaelburke
force-pushed
the
john-michaelburke/cpp-693
branch
from
1a123c0 to
a8b9b73
Compare
notoriaga
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts logic from #44 and moves it to two helper functions for reading/writing settings with a timeout duration to use with the context.