Skip to content

Conversation

@silverjam
Copy link
Contributor

@silverjam silverjam commented Apr 16, 2022

This prevents clang-tidy targets from generating a .clang-tidy in the source dir. This is a temporary fix, long term fix is here: swift-nav/cmake#109. This is necessary for swiftnav-rs build since the release and publish process (validated by cargo release minor) wants to make sure that the build doesn't modify things outside of the build dir.

@silverjam silverjam requested a review from jbangelo April 16, 2022 01:34
@silverjam
Copy link
Contributor Author

Running cargo release minor in the swiftnav-sys directory for swifnav-rs this solves the "should not modify things outside of output dir" problem.

@silverjam
Copy link
Contributor Author

Going to merge for now, still iterating on a long term solution here: swift-nav/cmake#109

@silverjam silverjam merged commit c96bba3 into master Apr 19, 2022
@silverjam silverjam deleted the silverjam/disable-clang-tidy-gen branch April 19, 2022 19:11
silverjam pushed a commit to swift-nav/swiftnav-rs that referenced this pull request Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants