Skip to content

Conversation

JADC362
Copy link
Contributor

@JADC362 JADC362 commented Jul 9, 2025

Jira

Design Notes

  • Move decimal_years_to_gps_time to libswiftnav->gnss_time.
  • Move gps_time_to_decimal_years to libswiftnav->gnss_time.
  • Move decimal_year_to_mjd to libswiftnav->gnss_time.

Testing

  • Nothing.

Related PRs

  • Nothing.

@JADC362 JADC362 force-pushed the jadc362/add_new_function branch from abd91a6 to 7b415d6 Compare July 9, 2025 20:07
@JADC362 JADC362 changed the title Move gps2decimal years Move decimal years functions Jul 9, 2025
@JADC362 JADC362 requested a review from jbangelo July 9, 2025 20:28
@JADC362 JADC362 force-pushed the jadc362/add_new_function branch from f8877e7 to df8361e Compare July 9, 2025 20:36
Copy link
Contributor

@jbangelo jbangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one style change

Comment on lines 275 to 280
/**
* @brief Converts a decimal year to a MJD (modified Julian date).
*
* @param epoch_years The epoch in decimal years representation.
* @return The epoch in MJD representation.
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style in this repo is to put the documentation comments into the source file.

@JADC362 JADC362 closed this Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants