Skip to content

Conversation

silverjam
Copy link
Contributor

@silverjam silverjam commented Mar 31, 2023

@silverjam
Copy link
Contributor Author

Anecdotally it looks like there's a good perf. bump with Python 3.11 on Windows

image

@swift-nav swift-nav deleted a comment from swiftnav-travis Mar 31, 2023
@swift-nav swift-nav deleted a comment from swiftnav-travis Mar 31, 2023
@swift-nav swift-nav deleted a comment from swiftnav-travis Mar 31, 2023
@swiftnav-travis
Copy link

Frontend and Release Workflow Started here

@swift-nav swift-nav deleted a comment from swiftnav-travis Mar 31, 2023
@silverjam silverjam marked this pull request as ready for review March 31, 2023 21:45
@silverjam silverjam requested review from a team and adrian-kong March 31, 2023 21:45
@silverjam silverjam changed the title python: try bumping to Python 3.11 again python: try bumping to Python 3.11 again [CPP-882] Mar 31, 2023
Copy link
Contributor

@adrian-kong adrian-kong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is so good
howd u manage to fix the import capnp error i was having with #913

tbh think it might be easier to remove py311 suffix so if it ever needs to change in future wont need digging everywhere but it this is very epic

@adrian-kong adrian-kong mentioned this pull request Apr 2, 2023
@silverjam
Copy link
Contributor Author

this is so good

howd u manage to fix the import capnp error i was having with #913

Not sure, was expecting to see that issue but it didn't pop up, so maybe it was a capnp bug for Python 3.11 that was fixed recently?

tbh think it might be easier to remove py311 suffix so if it ever needs to change in future wont need digging everywhere but it this is very epic

Yeah, I was thinking it'd be a lot easier to update in the future if we drop the version from the folder name. Will save that for another PR so I don't break this one.

@silverjam silverjam enabled auto-merge (squash) April 2, 2023 23:58
@swiftnav-travis
Copy link

Frontend and Release Workflow Started here

@silverjam silverjam merged commit 4ef4b43 into main Apr 3, 2023
@silverjam silverjam deleted the silverjam/py311 branch April 3, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants