Skip to content

Conversation

silverjam
Copy link
Contributor

@silverjam silverjam commented Aug 12, 2021

We have a bunch of messages that are for various "requests" such as "TCP
connection request", "file open request" and a "pause request".

This removes the ConnectRequest generic type and instead just uses the
main Message type.

We have a bunch of messages that are for various "requests" such as "TCP
connection request", "file open request" and a "pause request".

This removes the ConnectRequest generic type and instead just uses the
main `Message` type.
Copy link
Collaborator

@john-michaelburke john-michaelburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you are not a fan of the nesting 😄 . The simplified approach definitely reduces the amount of code.

@silverjam
Copy link
Contributor Author

I see you are not a fan of the nesting 😄 . The simplified approach definitely reduces the amount of code.

I was wondering if there was a specific technical reason we needed the generic message, but the nesting makes sense from a organizational standpoint too. I noticed that the *Request message are already in the main Message type, so was a little confused by that.

Motivation for removing this was to make porting to other protocol formats in the future easier. I wanted to see if I could try out msgpack/quicktype as an alternative to capnproto.

@john-michaelburke
Copy link
Collaborator

I see you are not a fan of the nesting 😄 . The simplified approach definitely reduces the amount of code.

I was wondering if there was a specific technical reason we needed the generic message, but the nesting makes sense from a organizational standpoint too. I noticed that the *Request message are already in the main Message type, so was a little confused by that.

Motivation for removing this was to make porting to other protocol formats in the future easier. I wanted to see if I could try out msgpack/quicktype as an alternative to capnproto.

Fair enough. Are you trying out of other proto alternatives to also see about possibly moving away from python to C++? Or just to compare performance with Capnproto?

@silverjam
Copy link
Contributor Author

Motivation for removing this was to make porting to other protocol formats in the future easier. I wanted to see if I could try out msgpack/quicktype as an alternative to capnproto.

Fair enough. Are you trying out of other proto alternatives to also see about possibly moving away from python to C++? Or just to compare performance with Capnproto?

It's for trying to move to a web based platform where capnproto support really doesn't exist.

@silverjam silverjam merged commit 02ce6d7 into main Aug 13, 2021
@silverjam silverjam deleted the silverjam/simplify-request-messages branch August 13, 2021 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants