Switch mpsc::channel to crossbeam channel for thread safe.[CPP-46] #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-michaelburke
changed the title
silverjam
approved these changes
Aug 28, 2021
|
Nice, I already needed to do this in the web experiment branch: main...silverjam/web-experiment#diff-5bb44f27b3b2237f87bf0e3bd4468c890d95896bdff4a5c0a02affc444bbc60aR392 |
john-michaelburke
deleted the
john-michaelburke/thread_safe_client_send
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small update to all our mpsc usage now will use crossbeam channels.
This will be useful for the update tab. Need to be able to send off updates to the frontend from a separate thread.