settings tab #109
settings tab #109
Conversation
notoriaga
force-pushed
the
steve/settings-tab2
branch
from
415c856 to
a19bb12
Compare
console_backend/src/settings_tab.rs
Outdated
|
|
||
| pub fn import(&mut self, path: String) -> Result<()> { | ||
| let mut f = { | ||
| let path = PathBuf::from(path.trim_start_matches("file://")); |
There was a problem hiding this comment.
Might need to test this functionality on windows. I have experienced issues in the past with an additional slash. See:
https://github.com/swift-nav/console_pp/blob/d0995c42c0a1bbd08b1ca39b27e5d505f4c2284e/resources/UpdateTabComponents/FileIOSelectLocalFileAndDestPath.qml#L99
What I was seeing is that the returned path would have a prefix with three slashes file:/// and replacing this with an empty string would work for windows but kill the root / for unix i.e. file:///usr/bin would become usr/bin
There was a problem hiding this comment.
I'll do some quick testing on Windows to see what happens
There was a problem hiding this comment.
I get this when trying to export settings on windows:
There was a problem hiding this comment.
Moved the leading '/' fix into Utils.fileUrlToString and switched the import/export to use that helper so should be good
|
Seeing an issue when attempting to adjust the
Reports the following error:
|
notoriaga
force-pushed
the
steve/settings-tab2
branch
2 times, most recently
from
bd58702 to
fe416bf
Compare
notoriaga
force-pushed
the
steve/settings-tab2
branch
from
fe416bf to
e9da34e
Compare
So it looks like there is no special case for this setting, rather the old console will update the |
|
I think we're almost there, I'm seeing an issue on Windows now when importing settings:
|
I could take a look on my windows machine tomorrow morning. |
Latest pushes fixes this issue and I'm able to import successfully |
3 participants
No description provided.