Skip to content

Conversation

john-michaelburke
Copy link
Collaborator

Implements

  • Handle bad log messages. When the console starts with Debug logging enabled there were a few messages that have escaped quotation chars which would cause the console to crash so this regex should remove those.
  • Add cli argument for setting the log level, on master the default log level was WARNING so no lower-level warnings would get dumped to a file/console until you start the console and then set the level. I think adding this as an argument is pretty reasonable, but if there is pushback, we can set it as hidden.
  • Add cli argument for dumping logs to stdout. I find it is much easier to debug an issue if we can dump the logs to a terminal window instead of a separate log file every time the console starts. Again if there is pushback we can set the argument to hidden.

@john-michaelburke john-michaelburke force-pushed the john-michaelburke/logging-fix branch 2 times, most recently from d7aca01 to 736609c Compare July 22, 2023 19:32
@john-michaelburke john-michaelburke force-pushed the john-michaelburke/logging-fix branch from 736609c to 596779b Compare July 22, 2023 21:27
@swiftnav-travis
Copy link

Frontend and Release Workflow Started here

@john-michaelburke john-michaelburke requested a review from a team July 22, 2023 21:49
@john-michaelburke john-michaelburke merged commit a3c1df7 into main Jul 23, 2023
@john-michaelburke john-michaelburke deleted the john-michaelburke/logging-fix branch July 23, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants