Skip to content

Conversation

adrian-kong
Copy link
Contributor

@adrian-kong adrian-kong commented Sep 4, 2023

adds tdkicm42670
baudrate enum dropdown
update deps

for 4.0 version

@adrian-kong adrian-kong requested a review from a team September 4, 2023 12:09
@adrian-kong adrian-kong changed the title Update deps, add TdkIcm42670, baudrate to enum dropdown [DIP-247] [v4.0] update deps, add TdkIcm42670, baudrate to enum dropdown [DIP-247] Sep 4, 2023
Copy link
Contributor

@pcrumley pcrumley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you have any idea why the memtest is failing? my guess is it is in the update deps stuff, since the other stuff looks pretty innocuous. I think you should break out the dependency updates because it seems unrelated to the logic changes.

@pcrumley
Copy link
Contributor

pcrumley commented Sep 7, 2023

it looks like mimalloc bump is the reason this is failing see: #1161

@silverjam
Copy link
Contributor

Please revert Cargo.lock -- dependencies should remain static for officially released builds. We need a full test cycle (including manual tests) to fully validate dependencies.

@silverjam
Copy link
Contributor

Please revert Cargo.lock -- dependencies should remain static for officially released builds. We need a full test cycle (including manual tests) to fully validate dependencies.

The changes to sbp and sbp-settings are fine, since they are our own dependencies.

@swiftnav-travis
Copy link

Frontend and Release Workflow Started here

@silverjam
Copy link
Contributor

Please make sure to forward port this to the main branch

@adrian-kong
Copy link
Contributor Author

Please make sure to forward port this to the main branch

these changes were missing from v4.0 branch only - main branchuses updated version of chrono

@adrian-kong adrian-kong merged commit eb265e0 into swift-toolbox-v4.0.0-branch Sep 8, 2023
@adrian-kong adrian-kong deleted the adrian/baudrate_enum branch September 8, 2023 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants