Minor Rust build improvements. #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-michaelburke
force-pushed
the
john-michaelburke/cicd
branch
from
688bfa0 to
e5c7e35
Compare
john-michaelburke
changed the title
silverjam
reviewed
Sep 10, 2021
console_backend/Cargo.toml
Outdated
| edition = "2018" | ||
|
|
||
| [profile.dev] | ||
| debug = 0 |
There was a problem hiding this comment.
Probably only want to do this in CI, right? What's the impact on the ability to use gdb if this is disabled?
There was a problem hiding this comment.
Yeah it is no good for gdb use. I confirmed that rustflags do get distributed correctly so added this to the environment vars.
john-michaelburke
force-pushed
the
john-michaelburke/cicd
branch
from
8dfe846 to
d0b54ba
Compare
silverjam
reviewed
Sep 11, 2021
Cargo.toml
Outdated
| [profile.release] | ||
| lto = true | ||
| codegen-units = 1 | ||
| opt-level = 3 |
There was a problem hiding this comment.
This is unnecessary since it's the default for release: https://doc.rust-lang.org/cargo/reference/profiles.html#release
There was a problem hiding this comment.
Maybe we could try 'z' or 's' and see if it shrinks the installer size?
silverjam
reviewed
Sep 11, 2021
Cargo.toml
Outdated
| [profile.release] | ||
| lto = true | ||
| codegen-units = 1 | ||
| opt-level = "z" |
There was a problem hiding this comment.
This didn't change anything, so we should probably dump it
silverjam
approved these changes
Sep 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three suggestions for speeding up CI from this article:
https://matklad.github.io/2021/09/04/fast-rust-builds.html
Results:
Consider a pass as a new commit to the PR triggering a rebuild.
Shows a large improvement on second plus passes through PRs.