Keithel qt/benchmark run env fixes #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* On my Windows machine, my git bash environment did not like that the executable path was specified with a relative path. I'm not exactly sure why, but changing these to an absolute path fixes the issue, and I believe should be ok for other environments. * The `cd -` is unnecessary as this is run in a subshell. This also was causing error in my environment.
* Also added info on prerequisites needed.
silverjam
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use absolute paths specifying exe in backend tests
On my Windows machine, my git bash environment did not like that the
executable path was specified with a relative path.
I'm not exactly sure why, but changing these to an absolute path fixes
the issue, and I believe should be ok for other environments.
The
cd -is unnecessary as this is run in a subshell. This also wascausing error in my environment.
Add info to readme on how to run the frontend benchmarks, and prerequisites needed.