Uprev Nuitka for Mac[CPP-331] #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-michaelburke
force-pushed
the
john-michaelburke/uprev-nuitka
branch
from
a5c4f68 to
04e708c
Compare
john-michaelburke
changed the title
john-michaelburke
force-pushed
the
john-michaelburke/uprev-nuitka
branch
3 times, most recently
from
8d014c3 to
3990f7b
Compare
john-michaelburke
force-pushed
the
john-michaelburke/uprev-nuitka
branch
from
3990f7b to
2918b63
Compare
silverjam
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appears this issue raised in nuitka:
Nuitka/Nuitka#1009
may be related to the CI problems we are seeing here:
#125
I have tested these changes patched into the #125 and it resolves the issue.
I realize we will eventually be dropping Nuitka but it is nice to know we can still build using their latest release!!
Unfortunately it does appear this has bumped up our Mac installer size (though some tuning of our remove script could fix this) so I have increased the disk usage bench size for mac in the meantime. If/when we swap installers this should not matter any more.