update sbp/sbp-settings #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let mut name = msg.name.to_string(); | ||
| if name.is_empty() { | ||
| name = NO_NAME.to_string(); | ||
| let name = if msg.name.as_bytes().iter().all(|b| b == &0) { |
There was a problem hiding this comment.
Interesting so a "no name" string that comes in would still have null characters? I guess you are just checking for the one null char that would indicate an empty string.
There was a problem hiding this comment.
I think (@silverjam could probably confirm) that because the string is fixed length it will always be 20 chars so whatever space you don't use will be a null byte. So the "empty" string in this case is 20 nulls
There was a problem hiding this comment.
Yeah, that is correct from what I remember
john-michaelburke
approved these changes
Oct 1, 2021
| PackedObsContentDepC, PackedOsrContent, | ||
| }, | ||
| SBP, | ||
| piksi::{Latency, MsgSpecan, MsgSpecanDep, MsgUartState, MsgUartStateDepa, Period}, |
There was a problem hiding this comment.
Not sure how big of a change it would be but since you are working on sbp message naming I will point out this MsgUartStateDepa seems to break the more common scheme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.