Add Hint for Building on macos #143
Conversation
The way rust-bindgen builds header search paths is not particularly robust on macos. This adds instructions for passing extra search paths to clang during bindgen. Also modifies the macos instructions to prefer the system install of clang to homebrew clang.
jungleraptor
requested review from
john-michaelburke,
notoriaga,
samvrlewis and
silverjam
README.md
Outdated
| git lfs pull | ||
| ``` | ||
|
|
||
| # Building for macos |
There was a problem hiding this comment.
Since this seems to be a one off maybe this could be changed to "Troubleshooting building for macos"
|
Also in the future there is a "devinfra" group you can add as a reviewer which should send out a blast to all of us so you dont have to add each one of us. I think most of the repos we touch have this feature except for maybe piksi_tools. |
|
If any of the repos don’t have it then the @devinfra team just needs to be
added as an owner/contributor— if you don’t have permission to fix that,
let me know and I’ll take care of it
…On Mon, Oct 4, 2021 at 11:21 AM John-Michael Burke ***@***.***> wrote:
Also in the future there is a "devinfra" group you can add as a reviewer
which should send out a blast to all of us so you dont have to add each one
of us. I think most of the repos we touch have this feature except for
maybe piksi_tools.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#143 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABMZDC5MEATVGY4LSCKWNDUFHWC5ANCNFSM5FJ6Q4MA>
.
|
|
@john-michaelburke I'll go ahead and try tweaking the variance in this PR, I'll merge once I have something that passes @isaactorz I merged a PR which causes the memory benchmark to be unstable with the current settings we have, I'll use this PR to find a better set of parameters, then merge |
Already on it! |
Ok, disengaging 😅 |
4 participants
The way rust-bindgen builds header search paths is not particularly
robust on macos. This adds instructions for passing extra search
paths to clang during bindgen. Also modifies the macos instructions
to prefer the system install of clang to homebrew clang.