Button shapes should not be ASCII chars [CPP-132] #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resources/Constants/Constants.qml
Outdated
| readonly property string importPath: "images/fontawesome/file-import.svg" | ||
| readonly property string warningPath: "images/fontawesome/exclamation-triangle.svg" | ||
| readonly property string connectButtonPath: "images/fontawesome/power-off-solid.svg" | ||
| readonly property string pauseButtonUrl: "qrc:///pause-solid.svg" |
There was a problem hiding this comment.
I agree the svg does look a little thicc. If you find a better one feel free to swap it in:
https://fontawesome.com/v5.15/icons?d=gallery&p=2&m=free
| id: positionPauseImg | ||
|
|
||
| anchors.centerIn: parent | ||
| width: 12 |
There was a problem hiding this comment.
For these numbers I like to throw them in the constants file for whichever QtObject is relevant for the tab for this one Constants.solutionPosition. and you can use the same for both height and width.
Things like smooth / antialiasing you can leave out.
resources/console_resources.qrc
Outdated
| <file>images/fontawesome/play-solid.svg</file> | ||
| <file>images/fontawesome/power-off-solid.svg</file> | ||
| <file>images/fontawesome/pause-solid.svg</file> | ||
| <file alias="pause-solid.svg">images/fontawesome/pause-solid.svg</file> |
There was a problem hiding this comment.
This is a pretty cool feature. We will need to take caution though as we will likely have a mixture of images from different sources and this abstracts the source from our constants file.
john-michaelburke
approved these changes
Oct 7, 2021
Replaced all instances of buttons using ascii with svg icons.
jungleraptor
force-pushed
the
itorres/pos-buttons-use-svg
branch
from
b0d00d2 to
fd8bcae
Compare
jungleraptor
changed the title
silverjam
reviewed
Oct 7, 2021
silverjam
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just wanted to solicit early feedback for some proposed changes:
SolutionPositionTab.qmlsince it's nested in theSolutionTabComponentsfolder. (../images/vsimages/).Constants.icons.pauseButtonUrl).