-
Notifications
You must be signed in to change notification settings - Fork 2
[CPP-33][CPP-70]Backend Memory Benchmark, Refactored Python Bench Runners #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ea3b172
to
25d325a
Compare
8593c15
to
42d6504
Compare
42d6504
to
74b02e4
Compare
console_backend/tests/mem_benches.rs
Outdated
break; | ||
} | ||
} | ||
let mems = ArrayView::from_shape(mem_readings_kb.len(), &mem_readings_kb).unwrap(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we push this to a helper function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Wasn't sure if you meant the process update step or the vec->arrayview so I abstracted both to helper functions.
6c4a949
to
04483df
Compare
CPP-33
Added a backend memory benchmark which processes a 1min sbp file reading the memory usage of the process frequently then assert it is within a few bounds:
CPP-70
Merged
Into
All data was moved from scattered locations to
console_backend/tests/data/
Other modification