add ability to load settings [CPP-368] #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notoriaga
changed the title
john-michaelburke
approved these changes
Oct 20, 2021
|
Sorry for the late reply here, but do we need to bundle a copy of the settings.yaml here in order for this to be equivalent to the old console? Before this someone like Dan would need to update sbp-settings GitHub repo, publish the crate, then update console_pp to get a new setting into the console. I was thinking if we bundled a settings.yaml then Dan or someone else would be able to update the file without having to worry about publishing crates and whatnot. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.