Skip to content

Conversation

silverjam
Copy link
Contributor

@silverjam silverjam commented Oct 26, 2021

Fixes a build error that @keithel-qt was seeing, briefly tested the generate-common-constants-rs task to see if it actually updated things, and it did:

diff --git a/console_backend/src/common_constants.rs b/console_backend/src/common_constants.rs
index 04884b5..f6732f2 100644
--- a/console_backend/src/common_constants.rs
+++ b/console_backend/src/common_constants.rs
@@ -29,7 +29,7 @@ use strum_macros::{Display, EnumString, EnumVariantNames};
 
 #[derive(Clone, Debug, Display, EnumString, EnumVariantNames, Eq, Hash, PartialEq)]
 pub enum Tabs {
-    #[strum(serialize = "TRACKING_SIGNALS")]
+    #[strum(serialize = "TRACKING_SIGNALS2")]
     TRACKING_SIGNALS,
     #[strum(serialize = "TRACKING_SKYPLOT")]
     TRACKING_SKYPLOT,
diff --git a/swiftnav_console/constants.py b/swiftnav_console/constants.py
index 0491de0..98caefc 100644
--- a/swiftnav_console/constants.py
+++ b/swiftnav_console/constants.py
@@ -2,7 +2,7 @@ from enum import Enum
 
 
 class Tabs(str, Enum):
-    TRACKING_SIGNALS = "TRACKING_SIGNALS"
+    TRACKING_SIGNALS = "TRACKING_SIGNALS2"
     TRACKING_SKYPLOT = "TRACKING_SKYPLOT"
     SOLUTION_POSITION = "SOLUTION_POSITION"
     SOLUTION_VELOCITY = "SOLUTION_VELOCITY"

The extract* task does at least generate a file in /tmp:

❯ cargo make extract-piksi-constants-rs
[cargo-make] INFO - cargo make 0.35.1
[cargo-make] INFO - Build File: Makefile.toml
[cargo-make] INFO - Task: extract-piksi-constants-rs
[cargo-make] INFO - Profile: development
[cargo-make] INFO - Running Task: legacy-migration
[cargo-make] INFO - Running Task: extract-piksi-constants-rs
Writing to: console_backend/src
/tmp/piksi_tools_constants.py ... console_backend/src/piksi_tools_constants.rs
[cargo-make] INFO - Build Done in 0.77 seconds.

❯ cat /tmp/piksi_tools_constants.py | wc -l
579

❯ ls -lsh /tmp/piksi_tools_constants.py 
12K -rw-r--r-- 1 jmob jmob 12K Oct 26 10:16 /tmp/piksi_tools_constants.py

@silverjam silverjam changed the base branch from main to keithel-qt/trackingtab-optimizations October 26, 2021 02:29
@keithel-qt keithel-qt force-pushed the silverjam/fix-up-constants-tasks branch 3 times, most recently from c7e8876 to 4f57b52 Compare October 26, 2021 16:37
@keithel-qt keithel-qt force-pushed the keithel-qt/trackingtab-optimizations branch from ec6b26c to 85e4ccc Compare October 26, 2021 16:38
@silverjam silverjam force-pushed the silverjam/fix-up-constants-tasks branch from 4f57b52 to 2bd82b2 Compare October 26, 2021 17:13
@silverjam silverjam changed the base branch from keithel-qt/trackingtab-optimizations to main October 26, 2021 17:13
@silverjam silverjam changed the title silverjam/fix up constants tasks make: port constants tasks to duckscript Oct 26, 2021
@silverjam silverjam requested review from a team and notoriaga October 26, 2021 17:18
@silverjam silverjam merged commit 71f360e into main Oct 26, 2021
@silverjam silverjam deleted the silverjam/fix-up-constants-tasks branch October 26, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants