add validator to settings text field [CPP-388] #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notoriaga
changed the title
notoriaga
force-pushed
the
steve/settings-validation
branch
from
8bc15f7 to
5326614
Compare
notoriaga
force-pushed
the
steve/settings-validation
branch
from
5326614 to
06bf488
Compare
notoriaga
commented
Oct 26, 2021
|
|
||
| } | ||
|
|
||
| floatValidator: DoubleValidator { |
There was a problem hiding this comment.
You can add upper/lower bounds for the numbers and a regex for the string validators, but this is probably as specific as we can be given the info from the settings yaml
|
Out of LFS bandwidth 😱 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally attempted to build something that checked if the input was valid, and if it wasn't it changed the highlight color from orange to red. Then I realized they had built in validators... These ones work differently though, they just don't let you type in invalid text at all. So if its an int field and you type letters they just don't register as key presses.