Skip to content

Conversation

notoriaga
Copy link
Contributor

@notoriaga notoriaga commented Oct 26, 2021

Right aligned the labels to make everything more even/table like. Also managed to get the long text fields to wrap. And also should be able to edit the settings that weren't working before (specifically you couldn't edit settings who's value was set to the empty string)

big-text

@notoriaga notoriaga requested a review from a team October 26, 2021 21:49
Copy link
Collaborator

@john-michaelburke john-michaelburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@silverjam silverjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Windows, looks good

@notoriaga notoriaga merged commit abf6c16 into main Oct 26, 2021
@notoriaga notoriaga deleted the steve/settings-view branch October 26, 2021 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants