Skip to content

Conversation

john-michaelburke
Copy link
Collaborator

No description provided.

Comment on lines 217 to 221
Rectangle {
height: 1
width: innerTable.width - 1
color: "transparent"
border.color: Constants.genericTable.borderColor
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what this was for so I removed it? Maybe it needs to stay? @samvrlewis

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it was added in this commit by Keith: 764a689

  • Adds a line bounding the bottom of the TableView. Allows the user to
    more clearly see the end of the visible portion of the table, even
    when the rows visible do not end at a whole row.

Maybe worth keeping?

@samvrlewis
Copy link
Contributor

This looks good, and I think was similar to what I originally tried (just copying from another table in the app) however I needed to swap out the HorizontalHeaderView for a repeater with rectangles so that the table heading would still appear even when the table was empty. I also wanted to have some empty space behind the table to make it look like a table, even when empty. So that it'd look something like this when empty.

image

It seems like it's potentially not worth the effort though as it was really hard to get it playing nicely with the resizeable headers and getting the backing white rectangle to be sized the same as the table as the table was resized. I think it's probably fine as implemented here:

Screenshot from 2021-10-28 09-21-03

I think I'll readd the bottom transparent rectangle and then merge this back into my branch, we can probably leave it as a further later optimisation to show the empty table.

@samvrlewis samvrlewis merged commit 0be264d into slewis/cpp-365 Oct 27, 2021
@samvrlewis samvrlewis deleted the john-michaelburke/cpp-365/column-headers branch October 27, 2021 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants